Fix dtype warning in HRPOpt: cast weights to float before multiplication#629
Open
Pranav-20186017 wants to merge 1 commit intoPyPortfolio:mainfrom
Open
Conversation
Contributor
|
Good catch but the problem should be addressed right at the definition of w, e.g. use w = pd.Series(1.0, index=ordered_tickers, dtype='float64') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses a Future Warning in
pypfopt/hierarchical_portfolio.pycaused by multiplying integer-type weights with float values. Due to stricter type enforcement, this would cause errors in future pandas versions.Files Changed
pypfopt/hierarchical_portfolio.pyFix
Explicitly cast weights array to float64 before arithmetic operations:
Testing Performed
pytest(no failures)Checklist
This patch ensures floating-point arithmetic and prevents future dtype conflicts in pandas.